feat: headerbar update notification [LIBS-344] #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcgee
force-pushed
the
feat-headerbar-update-notification
branch
from
e1b7dc3
to
42e1b13
Compare
5 tasks
14 tasks
KaiVandivier
requested changes
Oct 5, 2022
There was a problem hiding this comment.
Looks really good!! I noticed one bug: when hard-reloading in the one-client condition, the page got stuck at the PWA Loading Boundary (white screen) until reloading again. I found that removing these lines fixed it -- they were the old way of handling the hard-reload
After that's fixed, this is functionally good to go -- I'll post a few ideas for follow-ups and suggestions for making one or two things easier to understand for future maintainers too, but they're not at all necessary for merging 🙂
KaiVandivier
approved these changes
Oct 6, 2022
dhis2-bot
added a commit
that referenced
this pull request
Oct 6, 2022
# [10.1.0](v10.0.1...v10.1.0) (2022-10-06) ### Features * headerbar PWA update notifications [LIBS-344] ([#748](#748)) ([b245bf1](b245bf1))
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-176
Implements LIBS-344
Requires dhis2/app-runtime#1252Requires dhis2/ui#1153released asbetaRequires dhis2/ui#1156 (mergeuibeta to master)Description
This refactors the PWA update notification logic, moving update notification UI to the Profile menu. It also adds the app name, app version, and server version strings to the
useConfigcontext.