fix: allow env var override of api version #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dhis2-app-platform ready! Built with commit f2eebc2 |
varl
approved these changes
Sep 25, 2019
dhis2-bot
added a commit
that referenced
this pull request
Sep 25, 2019
## [1.4.3](v1.4.2...v1.4.3) (2019-09-25) ### Bug Fixes * allow env var override of api version ([#67](#67)) ([dc1b6df](dc1b6df))
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API version was incorrectly fixed at
32which stopped apps from targeting 2.31 servers. We should allow it to be overridden with theDHIS2_API_VERSIONenvironment variable, at least until we automatically configure the API version based on the server version.Thanks Terje for the bug report!