feat(cli): validate yarn.lock in 'start' and 'build' commands and add 'deduplicate' command #668
Conversation
mediremi
changed the title
|
|
||
| const duplicates = listDuplicates(deduped) | ||
| if (duplicates.size > 0) { | ||
| reporter.error('Failed to deduplicate the following packages:') |
There was a problem hiding this comment.
Failing to deduplicate with fixDuplicates may occur if there are multiple major versions of a dependency.
cli/src/commands/deduplicate.js
Outdated
| ` * ${chalk.bold(name)} (found versions ${versions.join(', ')})` | ||
| ) | ||
| } | ||
| process.exit(1) |
There was a problem hiding this comment.
You can use exit(code, message) from cli-helpers-engine for consistency.
# [8.2.0](v8.1.2...v8.2.0) (2021-10-07) ### Features * **cli:** validate yarn.lock in 'start' and 'build' commands and add 'deduplicate' command ([#668](#668)) ([8a8aa4d](8a8aa4d))
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Looks really awesome @mediremi , nice work! One comment - this will de duplicate in yarn.lock but not in node_modules which requires another |
Closes https://jira.dhis2.org/browse/LIBS-213
yarn.lockinstartandbuildcommands (warning instartbut error inbuild) by ensuring that there is only one version of@dhis2/app-runtime,@dhis2/d2-i18n,@dhis2/ui,reactandstyled-jsxdeduplicatecommand (which runs yarn-deduplicate)Implementation notes
i18nextas a sensitive singleton dependency,i18next-scannerdeclares the version of itsi18nextdependency as"*". This results in two different major versions ofi18next(@dhis2/d2-i18ndepends on^10.3, but latest major version is 21), whichyarn-deduplicatedoes not attempt to fix. Therefore, addingi18nextwould result inyarn buildfailing for all app-platform apps unlessyarn.locks are manually edited.yarn-deduplicate's code is included in this PR directly instead of being added as an npm dependency due to modifications required forlistDuplicatesandgetDuplicatedPackagesto work for our use case.