Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recording-mode): handle fulfilled requests after recording error #642

Merged

Conversation

KaiVandivier
Copy link
Contributor

Also reduces unnecessary error logging

https://jira.dhis2.org/browse/TECH-675

@KaiVandivier KaiVandivier requested a review from a team September 7, 2021 20:15
@KaiVandivier KaiVandivier merged commit 928e2cb into master Sep 8, 2021
@KaiVandivier KaiVandivier deleted the fix-handle-fulfilled-requests-after-recording-error branch September 8, 2021 07:26
dhis2-bot added a commit that referenced this pull request Sep 8, 2021
## [7.6.4](v7.6.3...v7.6.4) (2021-09-08)

### Bug Fixes

* **recording-mode:** handle fulfilled requests after recording error ([#642](#642)) ([928e2cb](928e2cb))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 7.6.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Sep 8, 2021
# [8.0.0-beta.4](v8.0.0-beta.3...v8.0.0-beta.4) (2021-09-08)

### Bug Fixes

* **dependencies:** update app-runtime to v3 ([8777699](8777699))
* **offline-interface:** prevent infinite update loop in Chrome ([#638](#638)) ([079f6ea](079f6ea))
* **recording-mode:** handle fulfilled requests after recording error ([#642](#642)) ([928e2cb](928e2cb))
* import index.css in index.js so styles are applied ([8db1bf8](8db1bf8))
* **shell:** create new stacking context for roots ([324a095](324a095))
* catch errors in completeRecording ([e67ae82](e67ae82))
* check whole URL against filter patterns ([5468114](5468114))
* only return sections with cached data from getCachedSections ([f6242d1](f6242d1))
* reopen indexedDB if global state resets ([0aded68](0aded68))
* return true if either cache or idb entry is removed ([43d8001](43d8001))
* simplify message payload to be compatible with firefox ([5e5a633](5e5a633))

### Features

* add service worker and pwa capabilities ([#550](#550)) ([225069e](225069e)), closes [#580](#580) [#582](#582) [#592](#592)
* allow RegEx for filter patterns in d2.config.js ([9699330](9699330))
* use new headerbar with online status indicator ([#626](#626)) ([3bd7d37](3bd7d37))

### BREAKING CHANGES

* **dependencies:** This updates the app-platform to version 3 of the
app-runtime. That means that this version of the app-platform will only
work with apps that use version 3 of the app-runtime.
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants