fix: catch service worker unregistration rejection #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
reviewed
Mar 17, 2021
amcgee
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
I think it's fine to catch all promise rejections here, we can fine-tune the error message or handling for different errors in the future.
I'm not sure this is the linked issue, actually - this error also happens when a serviceworker is registered on localhost - but it's not clear why it's happening here. In any case, it shouldn't hurt to catch rejections.
|
@amcgee can be reproduced by switching between before- & after-platform-upgrade commits/branches with Firefox and the setting that cookies should be deleted when closing the browser |
dhis2-bot
added a commit
that referenced
this pull request
Mar 24, 2021
## [6.0.1](v6.0.0...v6.0.1) (2021-03-24) ### Bug Fixes * catch service worker unregistration rejection ([#537](#537)) ([e1cbf3e](e1cbf3e))
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://jira.dhis2.org/browse/LIBS-155