fix: don't render application until we are sure the locale is initialized #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
approved these changes
Mar 1, 2021
varl
approved these changes
Mar 1, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 2, 2021
## [5.7.3](v5.7.2...v5.7.3) (2021-03-02) ### Bug Fixes * don't render application until we are sure the locale is initialized ([#525](#525)) ([4329e8e](4329e8e))
|
🎉 This PR is included in version 5.7.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we set the locale state in a
useEffect, there was a subtle race condition bug which could cause the application to render before the locale is set. When this happens, strings in the app are not correctly translated because the locale hasn't yet been switch from English to whatever the user has selected.