fix: namespace code-split moment locale chunks to separate them from app chunks #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediremi
approved these changes
Feb 18, 2021
dhis2-bot
added a commit
that referenced
this pull request
Feb 19, 2021
## [5.5.3](v5.5.2...v5.5.3) (2021-02-19) ### Bug Fixes * namespace code-split moment locale chunks to separate them from app chunks ([#507](#507)) ([cecb3c2](cecb3c2))
|
🎉 This PR is included in version 5.5.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor under-the-hood change.
Previously, all code-split chunks in an application used a numeric id + hash as their filename. This is technically fine, but it becomes hard to tell which chunks are important when there are 100+ moment locale chunks each 5-20kb in size and just a few "core" chunks numbered something like
135,136, and137which contain the actual application code.This change adds a webpack magic comment which results in moment locale chunks generated into the
static/js/moment-localesdirectory and named with the tag of the relevant locale instead of a random number (fr.HASH.jsinstead of13.HASH.js)