Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: encode username and password when posting to server in AuthBoundary #467

Merged
merged 2 commits into from
Oct 7, 2020
Merged

fix: encode username and password when posting to server in AuthBoundary #467

merged 2 commits into from
Oct 7, 2020

Conversation

awgaan
Copy link
Contributor

@awgaan awgaan commented Oct 7, 2020

Can now correctly log in with usernames/passwords that contain URL sensitive characters.

@awgaan
fix: encode username and password when posting to server in AuthBoundary
3058a99 
can now correctly log in with usernames/passwords that contain
URL sensitive characters
@awgaan awgaan requested a review from amcgee October 7, 2020 09:46
amcgee
amcgee approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @awgaan ! LGTM

@amcgee amcgee merged commit b0cc51d into master Oct 7, 2020
@amcgee amcgee deleted the auth-encode-credentials branch October 7, 2020 09:57
dhis2-bot added a commit that referenced this pull request Oct 7, 2020
@dhis2-bot
chore(release): cut 5.2.2 [skip ci]
93c41a6 
## [5.2.2](v5.2.1...v5.2.2) (2020-10-07)

### Bug Fixes

* adjust formatting in locales.hbs so it matches ESLint rules ([#466](#466)) ([658fa0b](658fa0b))
* encode username and password when posting to server in AuthBoundary ([#467](#467)) ([b0cc51d](b0cc51d))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awgaan @dhis2-bot @amcgee