feat: add d2-app-scripts deploy command #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcgee
requested review from
Birkbjo,
erikarenhill,
HendrikThePendric,
ismay and
varl
There was a problem hiding this comment.
Looks great, I left a couple of review comments. I mostly focussed on code-style, because I haven't worked on these type cli-scripts myself, so I can't really provide feedback on the general approach. I'll leave it up to another, more knowledgeable, colleague to either approve or request changes.
erikarenhill
reviewed
Sep 2, 2020
|
@erikarenhill @HendrikThePendric thanks for the reviews, updated |
HendrikThePendric
approved these changes
Sep 2, 2020
erikarenhill
approved these changes
Sep 2, 2020
dhis2-bot
added a commit
that referenced
this pull request
Sep 2, 2020
# [5.1.0](v5.0.0...v5.1.0) (2020-09-02) ### Features * add d2-app-scripts deploy command ([#451](#451)) ([655a053](655a053))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
d2-app-script deploycommand. It takes an existing application bundle (created withd2-app-scripts build) and pushes it to a running DHIS2 instance. For example: