Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Require @dhis2/ui v5 #439

Merged
merged 7 commits into from
Aug 14, 2020
Merged

feat: Require @dhis2/ui v5 #439

merged 7 commits into from
Aug 14, 2020

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Aug 14, 2020

BREAKING CHANGE: Requires @dhis2/ui@^5

HendrikThePendric and others added 7 commits June 15, 2020 13:07
* chore: replace ui-core & ui-widgets v4 with ui v5

BREAKING CHANGE: components should now be imported from `@dhis2/ui` and various components have had breaking changes in v5

* chore: fix lint error, add text lint to format script

Co-authored-by: Austin McGee <[email protected]>
# [5.0.0-alpha.1](v4.0.8...v5.0.0-alpha.1) (2020-06-15)

### chore

* replace ui-core & ui-widgets v4 with ui v5 ([#416](#416)) ([401aa32](401aa32))

### BREAKING CHANGES

* components should now be imported from `@dhis2/ui` and various components have had breaking changes in v5

* chore: fix lint error, add text lint to format script

Co-authored-by: Austin McGee <[email protected]>
# [5.0.0-alpha.2](v5.0.0-alpha.1...v5.0.0-alpha.2) (2020-08-14)

### Bug Fixes

* **dependency:** update babel-preset-env ([#421](#421)) ([09bcde7](09bcde7))
@amcgee amcgee changed the title chore: cut release with UI@5 from alpha feat: cut release with UI@5 from alpha Aug 14, 2020
@amcgee amcgee changed the title feat: cut release with UI@5 from alpha feat: Upgrade to @dhis2/ui v5 Aug 14, 2020
@amcgee amcgee changed the title feat: Upgrade to @dhis2/ui v5 feat: Require @dhis2/ui v5 Aug 14, 2020
@amcgee
Copy link
Member Author

amcgee commented Aug 14, 2020

We could possibly require @dhis2/ui@>5.3.3 instead of ^5.4.2 if we want to be lenient when a v6 is released, but we can make that a separate non-breaking change. We also might want to move external deps to PeerDeps, though that eliminates the advantage of hoisting all standard deps from app-platform... will defer that to a later decision.

Copy link
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcgee amcgee merged commit e600807 into master Aug 14, 2020
@amcgee amcgee deleted the alpha branch August 14, 2020 13:22
dhis2-bot added a commit that referenced this pull request Aug 14, 2020
# [5.0.0](v4.0.9...v5.0.0) (2020-08-14)

### Features

* Require @dhis2/ui v5 ([#439](#439)) ([e600807](e600807))

### BREAKING CHANGES

* require @dhis2/ui v5 - components should now be imported from @dhis2/ui and various components have had breaking changes in v5
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants