Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add login form data-test props #405

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

Mohammer5
Copy link
Contributor

This will add unique data-test props to the login form so that logging in can easily be automated in in-browser tests.

@Mohammer5 Mohammer5 requested a review from amcgee May 20, 2020 05:45
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good thanks @Mohammer5 !

@amcgee
Copy link
Member

amcgee commented May 20, 2020

@Mohammer5 Should we make this a fix so it triggers a release though?

@amcgee amcgee changed the title refactor: add login form data-test props fix: add login form data-test props May 20, 2020
@Mohammer5 Mohammer5 merged commit 9a63548 into master May 20, 2020
@Mohammer5 Mohammer5 deleted the Add_login_form_datatest branch May 20, 2020 08:49
dhis2-bot added a commit that referenced this pull request May 20, 2020
## [4.0.7](v4.0.6...v4.0.7) (2020-05-20)

### Bug Fixes

* add login form data-test props ([#405](#405)) ([9a63548](9a63548))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants