feat: generate a manifest, set PUBLIC_URL, and output a compliant zip #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dhis2-app-platform ready! Built with commit f608185 |
|
Thanks to @awgaan for pointing out the deployment issue! |
|
Closes #26 |
varl
approved these changes
Sep 6, 2019
erikarenhill
approved these changes
Sep 6, 2019
erikarenhill
suggested changes
Sep 6, 2019
Yeah, I thought about maybe overwriting that with the correct values but will remove it for now. |
|
Since this was approved by @varl and I addressed @erikarenhill 's comment I'm going to merge this after conflict resolution. Speak now if that's a problem! |
erikarenhill
approved these changes
Sep 10, 2019
dhis2-bot
added a commit
that referenced
this pull request
Sep 10, 2019
# [1.3.0](v1.2.3...v1.3.0) (2019-09-10) ### Features * generate a manifest, set PUBLIC_URL, and output a compliant zip ([#36](#36)) ([243454a](243454a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds manifest generation to the build script, automatically sets the PUBLIC_URL passed to CRA so that it will be installable on a DHIS2 instance, and outputs a DHIS2-compliant zip archive of the production build to
./build/bundle/dhis2-{name}-{version}.zip. This file can be uploaded directly to the App Management AppFuture enhancements:
activities.dhisfrom the manifest/api/apps/My-Simple-Application/rather than/apps/simpleor something equally pleasing to the eye