Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): add a default README.md file #335

Merged
merged 3 commits into from
Mar 26, 2020
Merged

fix(init): add a default README.md file #335

merged 3 commits into from
Mar 26, 2020

Conversation

awgaan
Copy link
Contributor

@awgaan awgaan commented Mar 25, 2020

Structure of README file is heavily inspired by the CRA's README file.
Closes #331

@awgaan awgaan requested a review from amcgee March 25, 2020 19:28
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start ! 👍

Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor wording change, otherwise looks great!

cli/config/init.README.md Outdated Show resolved Hide resolved
@amcgee
Copy link
Member

amcgee commented Mar 26, 2020

Thanks @awgaan - I'll squash when merging. I'm going to merge this as a fix as well.

@amcgee amcgee changed the title feat(init): add a default README.md file fix(init): add a default README.md file Mar 26, 2020
@amcgee amcgee merged commit 49b85ec into master Mar 26, 2020
@amcgee amcgee deleted the add-readme branch March 26, 2020 15:12
dhis2-bot added a commit that referenced this pull request Mar 26, 2020
## [3.2.9](v3.2.8...v3.2.9) (2020-03-26)

### Bug Fixes

* **init:** add a default README.md file ([#335](#335)) ([49b85ec](49b85ec))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add a README for the init command
4 participants