Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow login username or password to be shorter than 4 chars #325

Merged
merged 3 commits into from
Mar 21, 2020

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 20, 2020

On the DHIS2 user registration page we require a minimum of 4 characters when selecting a username. However, in the user management app the minimum is 2 characters.

Screen Shot 2020-03-20 at 10 29 12 PM

This change allows users created in the latter interface to log in through the AppShell login dialog.

@amcgee amcgee requested a review from varl March 20, 2020 21:31
@amcgee amcgee changed the title fix: allow usernames login username or password to be shorter than 4 chars fix: allow login username or password to be shorter than 4 chars Mar 20, 2020
@amcgee
Copy link
Member Author

amcgee commented Mar 20, 2020

Big thanks to @chathurawidanage for picking up on this inconsistency!!

@varl varl merged commit 625dbfa into master Mar 21, 2020
@varl varl deleted the fix/small-usernames branch March 21, 2020 10:58
dhis2-bot added a commit that referenced this pull request Mar 21, 2020
## [3.2.7](v3.2.6...v3.2.7) (2020-03-21)

### Bug Fixes

* allow usernames login username or password to be shorter than 4 characters ([#325](#325)) ([625dbfa](625dbfa))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants