Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly include styled-jsx as cli dependency #322

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 20, 2020

styled-jsx needs to be included as a dependency of d2-app-scripts to support styled-jsx babel transpilation - in some cases, it isn't properly hoisted from app-shell.

@amcgee amcgee requested a review from varl March 20, 2020 11:44
@amcgee amcgee merged commit c0eab17 into master Mar 20, 2020
@amcgee amcgee deleted the fix/explicit-styled-jsx-dep branch March 20, 2020 11:46
dhis2-bot added a commit that referenced this pull request Mar 20, 2020
## [3.2.6](v3.2.5...v3.2.6) (2020-03-20)

### Bug Fixes

* explicitly include styled-jsx as cli dependency ([#322](#322)) ([c0eab17](c0eab17))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants