Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show compilation errors when watching for changes #30

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Sep 4, 2019

There are two issues still existing after this PR -

  1. If there is a compilation error on startup, we get a FATAL code and have to abort (which we do properly now). We should continue to watch for changes until it gets fixed
  2. When we do abort, the CRA start script continues to run in the background and gets orphaned by the parent process

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for dhis2-app-platform ready!

Built with commit 98c6420

https://deploy-preview-30--dhis2-app-platform.netlify.com

Copy link

@erikarenhill erikarenhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally, works as described

@amcgee amcgee merged commit 7bbdd5c into master Sep 5, 2019
@amcgee amcgee deleted the fix/show-compilation-errors branch September 5, 2019 12:05
dhis2-bot added a commit that referenced this pull request Sep 5, 2019
## [1.2.2](v1.2.1...v1.2.2) (2019-09-05)

### Bug Fixes

* show compilation errors when watching for changes ([#30](#30)) ([7bbdd5c](7bbdd5c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants