fix: control the viewport, always show the headerbar, size app container #267
Conversation
|
Do you mean that the headerbar should always be visible at the top of the screen, even when the user scrolls down on the page? |
Yeah, @cooper-joe species the headerbar to be always visible. Instead of scrolling the whole page you scroll in the content div. we could also affix the headerbar above the content but I think I like this better (and easier because you don’t need a matching-height buffer). |
|
@amcgee this could be merged as a feature depending if "sticky headerbar" is considered an addition or a bug. |
|
It could, not really sure. The lack of viewport sizing was definitely a big.
… Le 16 janv. 2020 à 15:47, Viktor Varland ***@***.***> a écrit :
@amcgee this could be merged as a feature depending if "sticky headerbar" is considered an addition or a bug.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yeah, ideally we'd land two commits on Since this isn't a feature that a user can opt in to use, considering and landing it as a single |
## [3.2.1](v3.2.0...v3.2.1) (2020-01-16) ### Bug Fixes * control the viewport, always show the headerbar, size app container ([#267](#267)) ([3823d8a](3823d8a))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This ensures that the appShell takes full control of the browser viewport, that the Headerbar is "sticky" (actually never moves), and that the app has a sized container so that it can properly render full-height divs.
This is required for the DV port, since it currently can't know how high the viewport is without a hard-coded Headerbar height