fix: resolve the absolute path to the current directory #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `cli-app-scripts test` in an app, the line:
extends: './app.babel.config'
Incorrectly resolves from the current working directory:
Cannot find module './app.babel.config' from '/home/varl/dev/dhis2/apps/usage-analytics'
We can use `path.resolve` + `__dirname`[1] to resolve the absolute path
of the `app.babel.config.js` file relatively to `babel.config.js`.
[1] https://nodejs.org/api/globals.html#globals_dirname
dhis2-bot
added a commit
that referenced
this pull request
Jan 16, 2020
## [3.1.4](v3.1.3...v3.1.4) (2020-01-16) ### Bug Fixes * resolve the absolute path to the current directory ([#266](#266)) ([190c111](190c111))
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
cli-app-scripts testin an app, the line:Incorrectly resolves from the current working directory:
We can use
path.resolve+__dirname[1] to resolve the absolute pathof the
app.babel.config.jsfile relatively tobabel.config.js.[1] https://nodejs.org/api/globals.html#globals_dirname