feat: allow customization of the dhis2 app icon #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varl
reviewed
Jan 16, 2020
varl
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
This is good enough for now. I think having a fallback icon for the app is also "nice".
My only comment is that we should provide a "generic" app icon (@cooper-joe) instead of the DHIS2 logo, but that can go in the next iteration to avoid blocking this feature.
|
@varl definitely agree, cheers! |
dhis2-bot
added a commit
that referenced
this pull request
Jan 16, 2020
# [3.2.0](v3.1.4...v3.2.0) (2020-01-16) ### Features * allow customization of the dhis2 app icon ([#265](#265)) ([86f1cd7](86f1cd7))
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certainly more versatile ways to do this, but this seems like a preetty simple fix for the moment. I'm very open to counter-suggestions (specifying any file in
d2.config.js, for instance) or recommendations on another filename (currentlypublic/dhis2-app-icon.png). We could also not provide a default and require that the app developer specifies one, but that seems harsh for the moment.For now the favorite icon will remain the DHIS2 logo (though undocumented, this can also be overridden in the same way, you just have to do it for a lot of different file sizes).
Fixes #212