Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): allow eslint to internally require the custom config #264

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix(eslint): allow eslint to internally require the custom config #264

merged 1 commit into from
Jan 15, 2020

Conversation

varl
Copy link
Contributor

@varl varl commented Jan 15, 2020

Fixes #263.

@varl varl requested a review from amcgee January 15, 2020 06:19
amcgee
amcgee approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM

@amcgee amcgee merged commit 27d6693 into master Jan 15, 2020
@amcgee amcgee deleted the fix/shell-eslint-extension branch January 15, 2020 09:35
dhis2-bot added a commit that referenced this pull request Jan 15, 2020
@dhis2-bot
chore(release): cut 3.1.3 [skip ci]
1352058 
## [3.1.3](v3.1.2...v3.1.3) (2020-01-15)

### Bug Fixes

* **eslint:** allow eslint to internally require the custom config ([#264](#264)) ([27d6693](27d6693)), closes [#263](#263)
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shell ESLint file incorrectly extends cli-style ESLint config
3 participants
@varl @dhis2-bot @amcgee