Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly support all CRA babel plugins #262

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Jan 14, 2020

Adds support for dynamic imports, optional chaining (?.), and nullish coalescing (??), all of which are supported by CRA (see the 3.3.0 changelog) but were blocked by our babel pre-compiler.

Also adds the plugin react-require, which will automatically insert import React from 'react' to any file which contains JSX. This fixes #213

@amcgee amcgee requested review from edoardo and varl January 14, 2020 16:27
@varl
Copy link
Contributor

varl commented Jan 14, 2020

For reference: https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md#330-2019-12-04

@amcgee amcgee merged commit 5f1d5dd into master Jan 14, 2020
@amcgee amcgee deleted the fix/add-babel-syntax-plugins branch January 14, 2020 17:33
dhis2-bot added a commit that referenced this pull request Jan 14, 2020
## [3.1.2](v3.1.1...v3.1.2) (2020-01-14)

### Bug Fixes

* correctly support all CRA babel plugins ([#262](#262)) ([5f1d5dd](5f1d5dd))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Files with only styled-jsx template literals require a React import
3 participants