Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port overrides not working #211

Closed
amcgee opened this issue Dec 11, 2019 · 2 comments · Fixed by #223
Closed

Port overrides not working #211

amcgee opened this issue Dec 11, 2019 · 2 comments · Fixed by #223
Assignees
@amcgee
Labels
bug Something isn't working released

Comments

@amcgee
Copy link
Member

amcgee commented Dec 11, 2019

None of the options to change the port of the test server (yarn start --port xxx, PORT=xxx yarn start, auto-fallback after port conflict) actually change the port, it is always set to 3000. The environment PORT passed to CRA is undefined
@amcgee
Copy link
Member Author

amcgee commented Dec 11, 2019

Thanks @edoardo for helping find all the things I broke!!

@amcgee amcgee self-assigned this Dec 11, 2019
@amcgee amcgee added the bug Something isn't working label Dec 11, 2019
@amcgee amcgee mentioned this issue Dec 18, 2019
Merged
@dhis2-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcgee amcgee

Labels
bug Something isn't working released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly set custom and fallback port overrides dhis2/app-platform
2 participants
@amcgee @dhis2-bot