feat: publish shell and adapter, fix dependency resolution #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @varl for the idea to try this approach and the productive brainstorming! |
|
This looks pretty clean, @amcgee. Good work! |
dhis2-bot
added a commit
that referenced
this pull request
Jan 3, 2020
# [3.1.0](v3.0.2...v3.1.0) (2020-01-03) ### Features * publish shell and adapter, fix dependency resolution ([#221](#221)) ([dd1c51a](dd1c51a))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
amcgee
added a commit
that referenced
this pull request
Jan 30, 2020
The documentation was out-of-date with the latest behavior after #221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
Use npm to install
app-shellandapp-adapterfrom the registry, rather than bundling them as assets. This allows us to resolve all dependencies through the top-level application'snode_modules, rather than through the subsidiary shell'snode_modules. This also allows shell dependencies to be overridden with theresolutionsfield in the app'spackage.json, though that's not generally recommended.To make this even cleaner, we should show a warning if the hoisted version of an app-shell dependency doesn't match the version resolved from the shell itself, and also detect when multiple copies of dependencies (particularly singleton ones like
reactandstyled-jsx) end up in the bundle.