Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 #198

Merged
merged 5 commits into from
Dec 9, 2019
Merged

chore(deps): upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 #198

merged 5 commits into from
Dec 9, 2019

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Dec 6, 2019 •
edited by amcgee
Loading

This is needed for DV where the new options UI uses features and fixes in @dhis2/ui-core introduced from version 4.

BREAKING CHANGE: This will break applications expecting the ui-core v3 API

@edoardo edoardo requested a review from amcgee December 6, 2019 08:48
@netlify
Copy link

netlify bot commented Dec 6, 2019 •
edited
Loading

Deploy preview for dhis2-app-platform canceled.

Built with commit a00d647

https://app.netlify.com/sites/dhis2-app-platform/deploys/5dee801c0bdb07000b9b6b52

@varl
Copy link
Contributor

varl commented Dec 9, 2019

This requires changes in:

https://github.com/dhis2/app-platform/blob/master/shell/adapter/src/AuthBoundary/LoginModal.js

the onChange handlers now have the signature object, event.

@edoardo
Copy link
Member Author

edoardo commented Dec 9, 2019

This requires changes in:

https://github.com/dhis2/app-platform/blob/master/shell/adapter/src/AuthBoundary/LoginModal.js

the onChange handlers now have the signature object, event.

Good catch.
Fixed.

@amcgee
Copy link
Member

amcgee commented Dec 9, 2019

I think we currently have two copies of ui-core in the shell, since our version of ui-widgets uses [email protected]? We should think about how to consistently upgrade these (especially with breaking changes, since these will break apps) in general.

We probably don't want to wait for it, but this would be a good use-case for #125 - it would probably have caught the Login Dialog failure due to ui-core API changes

amcgee
amcgee reviewed Dec 9, 2019
View reviewed changes
shell/yarn.lock Outdated
dependencies:
prop-types "^15"

"@dhis2/[email protected]", "@dhis2/ui-core@^3.12.0":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these versions of ui-core coming from?

@amcgee
Copy link
Member

amcgee commented Dec 9, 2019 •
edited
Loading

Where are these versions of ui-core coming from?

This was from an older version of ui-widgets which bundled its own ui-core - fixed in 70d4f84 ad a80e9a5

@amcgee amcgee changed the title chore(deps): bump @dhis2-ui-core to 4.1.1 chore(deps): upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 Dec 9, 2019
@amcgee amcgee mentioned this pull request Dec 9, 2019
Closed
@amcgee
Copy link
Member

amcgee commented Dec 9, 2019

This was actually broken because LoginDialog still referenced the non-existant Modal.Title, Modal.Content, and Modal.Actions components - I had to switch them here a00d647

@edoardo probably good to get in the habit of running the example app (yarn start in root directory) to sanity-check breaking dependencies, especially until we have #125

I also added BREAKING CHANGE to the issue description, we need to make sure this is included in the commit footer when merging.

@amcgee amcgee merged commit 07c2187 into master Dec 9, 2019
@amcgee amcgee deleted the chore/ui-core-dep-upgrade branch December 9, 2019 17:16
dhis2-bot added a commit that referenced this pull request Dec 9, 2019
@dhis2-bot
chore(release): cut 3.0.0 [skip ci]
17832f9 
# [3.0.0](v2.0.0...v3.0.0) (2019-12-09)

### Features

* **deps:** upgrade @dhis2/ui-core to 4.1.1 and @dhis2/ui-widgets to 2.0.4 ([#198](#198)) ([07c2187](07c2187))

### BREAKING CHANGES

* **deps:** This will break applications which use the v3 API of `@dhis2/ui-core` components
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@edoardo @varl @amcgee @dhis2-bot