Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update yarn.lock, otherwise install fails with cryptic error #150

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Nov 6, 2019

The following error (cryptic at best) occurred because yarn.lock wasn't correctly updated in the shell and shell adapter. This was problematic specifically because we run yarn install --frozen-lockfile --prefer-offline, which means the lockfile can't be out of date.

error Couldn't find package "@dhis2/ui-core@^3.12.0" required by "@dhis2/app-adapter@file:./adapter" on the "npm" registry.
 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
 Error: Couldn't find package "@dhis2/ui-widgets@^2.0.0" required by "@dhis2/app-adapter@file:./adapter" on the "npm" registry.
    at MessageError.ExtendableBuiltin (/Users/awm/.yarn/lib/cli.js:721:66)
    at new MessageError (/Users/awm/.yarn/lib/cli.js:750:123)
    at PackageRequest.<anonymous> (/Users/awm/.yarn/lib/cli.js:36528:17)
    at Generator.throw (<anonymous>)
    at step (/Users/awm/.yarn/lib/cli.js:304:30)
    at /Users/awm/.yarn/lib/cli.js:317:13

Side note : we should add functional "can bootstrap and run an app from scratch" tests

@amcgee amcgee requested a review from varl November 6, 2019 14:58
@amcgee
Copy link
Member Author

amcgee commented Nov 6, 2019

@varl going ahead with this merge, since prod is broken.

@amcgee amcgee merged commit 5e5e668 into master Nov 6, 2019
@amcgee amcgee deleted the fix/yarn-lock branch November 6, 2019 15:18
dhis2-bot added a commit that referenced this pull request Nov 6, 2019
## [1.5.7](v1.5.6...v1.5.7) (2019-11-06)

### Bug Fixes

* update yarn.lock, otherwise install fails with cryptic error ([#150](#150)) ([5e5e668](5e5e668))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.5.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@varl
Copy link
Contributor

varl commented Nov 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants