Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing commits/PRs on main #377

Closed
stlava opened this issue Apr 9, 2024 · 2 comments · Fixed by #384
Closed

Missing commits/PRs on main #377

stlava opened this issue Apr 9, 2024 · 2 comments · Fixed by #384
Labels
kind/question Something requiring a response. Stale

Comments

@stlava
Copy link

stlava commented Apr 9, 2024

Question.

I found that a few PRs made back in 2022 were merged into master instead of main and now the two histories (and versions) differ. I didn't piece the timeline together but what I assume happened was a few PRs were opened against master and the repo changed default branches.

Specifically a race condition fixed in #294 got merged into master and never made it to main.

The way I found this was a project I'm working on uses v0.0.0-20220403145359-8e850b710d6d and I had trouble finding that hash version until it occurred to check the master branch which may have been default at the time.

@stlava stlava added the kind/question Something requiring a response. label Apr 9, 2024
Copy link

This issue has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@StarpTech
Copy link
Contributor

Hi, any updates? We run into the same race condition and it would be very sad if we wouldn't find one to cherry pick the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Something requiring a response. Stale
Development

Successfully merging a pull request may close this issue.

2 participants