Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subnet rescue command #527

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Add subnet rescue command #527

merged 12 commits into from
Jun 25, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jun 24, 2024 •
edited
Loading

This implements the command:
dre subnet --id XXX rescue --keep-nodes <nodes_features>

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner June 24, 2024 18:48
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft June 24, 2024 18:48
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review June 25, 2024 15:30
sasa-tomic
sasa-tomic reviewed Jun 25, 2024
View reviewed changes
rs/cli/src/cli.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Show resolved Hide resolved
sasa-tomic
sasa-tomic approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 00865c3 into main Jun 25, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the add-subnet-rescue-command branch June 25, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietrodimarco-dfinity @sasa-tomic