Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Update build configuration and version information #121

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

sasa-tomic
Copy link
Member

@sasa-tomic sasa-tomic commented Jan 26, 2024

Before the change, with bazel builds:

./bazel-bin/rs/cli/dre --version
 INFO  dre > Running version 
dre 

After the change:

$ bazel run //rs/cli:dre -- --version
[...]
 INFO  dre > Running version 0.2.0-5aaa4fa-dirty
dre 0.2.0-5aaa4fa-dirty

The version is picked up automatically from Cargo.toml and git. Build is done as usual.

Bazel changes based on https://github.com/bazelbuild/rules_rust/blob/fe610dab73c3c61560a547bc661177dd5115fed7/examples/version_stamping/BUILD.bazel#L15

Before:
```
 INFO  dre > Running version
dre
```

Now:
```
 INFO  dre > Running version 0.2.0-879cd7ca9bd59abad41e153668b23fcae41651c8
dre 0.2.0-879cd7ca9bd59abad41e153668b23fcae41651c8
```
@sasa-tomic sasa-tomic requested a review from a team as a code owner January 26, 2024 18:02
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change!

@sasa-tomic sasa-tomic added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit c85c81f Jan 29, 2024
3 checks passed
@sasa-tomic sasa-tomic deleted the sat-bazel-embed-version branch January 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants