Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating guest fails on vagrant >= 2.3.5 #290

Closed
stephenreay opened this issue Jun 29, 2023 · 5 comments · Fixed by #291
Closed

Updating guest fails on vagrant >= 2.3.5 #290

stephenreay opened this issue Jun 29, 2023 · 5 comments · Fixed by #291

Comments

@stephenreay
Copy link
Contributor

Vagrant 2.3.5 moved to shipping Ruby3;

When updating the guest, an error is thrown from update_guest.rb:20, due to this change.
stephenreay added a commit to Koalephant/vagrant-hostmanager that referenced this issue Jun 29, 2023
@stephenreay
Use keyword argument in place of a hash for I18n.t() calls
a25ea2a 
Fixes devopsgroup-io#290
@stephenreay stephenreay mentioned this issue Jun 29, 2023
Merged
@wimsymons
Copy link

Who can merge and release this?

@wimsymons
Copy link

According to https://rubygems.org/gems/vagrant-hostmanager, that is @seth-reeser or @smdahlen. Can you guys take a look? 🙏

@zipkid
Copy link

zipkid commented Jul 24, 2023

It's a bit early in the USA a.t.m... hopefully they will wake up soon.

@wimsymons
Copy link

Thank you very much for the merge, but a new release is needed as well to make it work on vagrant 2.3.5+.

Can you make this happen?

@wimsymons
Copy link

@seth-reeser thank you for 1.8.10! Much appreciated 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix calls to I18n.t() using a hash Koalephant/vagrant-hostmanager
3 participants
@zipkid @stephenreay @wimsymons