Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket support? #7

Open
courajs opened this issue Jun 25, 2019 · 4 comments
Open

WebSocket support? #7

courajs opened this issue Jun 25, 2019 · 4 comments

Comments

@courajs
Copy link

courajs commented Jun 25, 2019

This seems like it would probably be a pretty big feature to add, but have you thought through web socket support? I'm kinda fuzzy on how I would even want it to work, but I might be willing to build it if there was a clear path forward

@PatKoperwas
Copy link
Collaborator

I've thought about it, been waiting for someone to raise an issue before I gave it any more time. Are you looking to proxy the websocket connection itself, or is there some other use case?

@courajs
Copy link
Author

courajs commented Jul 10, 2019

Yeah, I have a server with both http test endpoints and a web socket live layer, and was trying to use tychus for it. I’ve instead been using tychus for the http endpoints but making the websocket connection directly to the underlying server.
Honestly, the only real downside is that I need to put two hosts into config instead of one

@PatKoperwas
Copy link
Collaborator

Should be possible, would need to use Hijacker (https://golang.org/pkg/net/http/#Hijacker) when the request is sending upgrade headers

@PatKoperwas
Copy link
Collaborator

I might take a stab at this sometime this week or next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants