Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] after upgrade to 2.0.0 build is broken #7

Closed
lhein opened this issue Feb 17, 2021 · 4 comments
Closed

[Bug Report] after upgrade to 2.0.0 build is broken #7

lhein opened this issue Feb 17, 2021 · 4 comments
Assignees
Labels
Bug Report This is a bug report

Comments

@lhein
Copy link

lhein commented Feb 17, 2021

In our project we had a PR created today for a version bump from 1.2.6 to 2.0.0. The build for the PR is broken and I am a out of ideas what could cause it.

See redhat-developer/vscode-didact#420 for the PR created by dependabot.

The build fails with the following error:

> [email protected] compile /home/circleci/vscode-didact
> tsc -p ./

src/test/suite/didact.test.ts:30:28 - error TS7016: Could not find a declaration file for module 'async-wait-until'. '/home/circleci/vscode-didact/node_modules/async-wait-until/dist/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/async-wait-until` if it exists or add a new declaration (.d.ts) file containing `declare module 'async-wait-until';`

30 import waitUntil = require('async-wait-until');
                              ~~~~~~~~~~~~~~~~~~


Found 1 error.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] compile: `tsc -p ./`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2021-02-17T08_06_24_845Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] vscode:prepublish: `npm run clean && npm run compile`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] vscode:prepublish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/circleci/.npm/_logs/2021-02-17T08_06_25_008Z-debug.log

Is that a problem with the 2.0.0 version?

@devlato
Copy link
Owner

devlato commented Feb 17, 2021

@lhein Thanks for reporting!
Could you try this, please?

import { waitUntil } from 'async-wait-until';

@devlato
Copy link
Owner

devlato commented Feb 17, 2021

@lhein the issue's fixed, please upgrade to 2.0.1 🙂
(turns out I didn't update the files property of package.json before publishing 2.0.0)

@devlato devlato closed this as completed Feb 17, 2021
@lhein
Copy link
Author

lhein commented Feb 18, 2021

Thanks for fixing the issue, @devlato.

@devlato
Copy link
Owner

devlato commented Feb 18, 2021

@lhein No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report This is a bug report
Projects
None yet
Development

No branches or pull requests

2 participants