Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate how Desktop handles shell.moveItemToTrash usage when Recycle Bin disabled #5157

Open
shiftkey opened this issue Jul 13, 2018 · 0 comments
Open

investigate how Desktop handles shell.moveItemToTrash usage when Recycle Bin disabled #5157

shiftkey opened this issue Jul 13, 2018 · 0 comments
Labels
electron Issues related to our use of Electron that may need updates to Electron or upstream fixes investigation-needed Likely bugs, but haven't been reliably reproduced by a reviewer windows Issues specific Desktop usage on Windows

Comments

@shiftkey
Copy link
Member

shiftkey commented Jul 13, 2018 •
edited
Loading

See related discussion: #4703 (comment)

We use this in a few places, and it'd be great to:

  • confirm the impact to Desktop
  • identify how we can programatically detect the absence of the Recycle Bin on a drive
  • skip the "Move to Trash" option when removing a repository
  • figure out what to do if "Discard Changes" cannot be done cleanly (warn the user?)
@shiftkey shiftkey added tech-debt Issues and pull requests related to addressing technical debt or improving the codebase windows Issues specific Desktop usage on Windows labels Jul 13, 2018
@shiftkey shiftkey mentioned this issue Jul 13, 2018
Merged
@msftrncs msftrncs mentioned this issue Dec 15, 2018
Closed
@shiftkey shiftkey added investigation-needed Likely bugs, but haven't been reliably reproduced by a reviewer and removed tech-debt Issues and pull requests related to addressing technical debt or improving the codebase labels Feb 3, 2019
@shiftkey shiftkey added the electron Issues related to our use of Electron that may need updates to Electron or upstream fixes label Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
electron Issues related to our use of Electron that may need updates to Electron or upstream fixes investigation-needed Likely bugs, but haven't been reliably reproduced by a reviewer windows Issues specific Desktop usage on Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shiftkey