Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible to download with http proxy? #14

Open
kiinoo opened this issue Apr 2, 2023 · 6 comments
Open

possible to download with http proxy? #14

kiinoo opened this issue Apr 2, 2023 · 6 comments

Comments

@kiinoo
Copy link

kiinoo commented Apr 2, 2023

see the title

@dertuxmalwieder
Copy link
Owner

In theory, 0.12.0 added proxy support. If it does not work for you, I’ll need more information.

@kiinoo
Copy link
Author

kiinoo commented Apr 2, 2023

thanks, I probably did not make it right. what I did is setting proxy like this (in windows):

set HTTPS_PROXY=127.0.0.1:7890
set HTTP_PROXY=127.0.0.1:7890

and then ran yaydl <url>

@dertuxmalwieder
Copy link
Owner

Proxy support is implemented per site. I haven’t found the time to add it to all of them yet, see e.g. b8374d6

Which site did you try? (I don’t use a proxy at home, so debugging is harder than you’d think right now…)

@kiinoo
Copy link
Author

kiinoo commented Apr 3, 2023

Youtube.

I've seen the .commit, but could not figure out how to use it by looking through code like this: env_proxy::for_url(&url)

@dertuxmalwieder
Copy link
Owner

Hmm. Basically, all calls to ureq:: need to be wrapped in env_proxy. YouTube does not do that yet. I will try to fix it later, I’ll post here.

@dertuxmalwieder
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants