This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
ADD: use requestIdleCallback if its available instead of setTimeout t… #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o provide a smoother dev experience
stephenmathieson
suggested changes
Jan 3, 2019
| var timeout; | ||
| var _createElement; | ||
| var components = {}; | ||
| var nodes = []; | ||
| var cache = {}; | ||
|
|
||
| var scheduleFunction = requestIdleCallback || setTimeout; |
There was a problem hiding this comment.
This will raise a ReferenceError: requestIdleCallback is not defined in environments that do no have requestIdleCallback.
We should either pad this more defensively, or use a polyfill (eg npmjs.com/requestidlecallback).
| } | ||
|
|
||
| var deferred = createDeferred() | ||
| var scheduleOptions = scheduleFunction === requestIdleCallback ? { timeout: timeout } : timeout; |
There was a problem hiding this comment.
This too will raise a ReferenceError.
stephenmathieson
added a commit
that referenced
this pull request
Jan 8, 2019
This patch builds on #59 (hat tip to @agreene-coursera!!) and uses `requestIdleCallback` rather than `setTimeout` in environments that support it. If the host environment does not support `requestIdleCallback`, a shim will be used (via [`npmjs.com/requestidlecallback`](https://www.npmjs.com/package/requestidlecallback)). Closes #59.
4 tasks
stephenmathieson
added a commit
that referenced
this pull request
Jan 9, 2019
This patch builds on #59 (hat tip to @agreene-coursera!!) and uses `requestIdleCallback` rather than `setTimeout` in environments that support it. If the host environment does not support `requestIdleCallback`, a shim will be used (via [`npmjs.com/requestidlecallback`](https://www.npmjs.com/package/requestidlecallback)). Closes #59.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o provide a smoother dev experience
Description
Currently the package is using an arbitrary timeout to collect changed elements for batch checking them. This PR switches from a timeout to a wait for an idle period (requestIdleCallback) so that checks don't block UI or business logic. This should make the perceived experience of using the package much smoother
Reviewer checks
Required fields, to be filled out by PR reviewer(s)