feat: Support IntelliSense autocomplete for valid registries when using import map specifiers

[jsejcksn]

I would like to see IntelliSense autocompletion for imports from valid registries when those registries have been mapped to arbitrary specifiers using an import map.

I'm aware that this issue is being tracked in the CLI repo in regard to LSP support at this issue. I'm creating an issue here in this repo specifically for tracking behavior about the extension in VS Code, and to document the current behavior (below).

I have an example directory structure like this:

% ls -AF
.vscode/		import_map.json
deno.jsonc		main.ts

% cat .vscode/settings.json 
{
  "deno.enable": true
}

% cat deno.jsonc 
{
  "importMap": "./import_map.json"
}

% cat import_map.json 
{
  "imports": {
    "std/": "https://deno.land/[email protected]/"
  }
}

% cat main.ts 

% deno --version
deno 1.28.2 (release, x86_64-apple-darwin)
v8 10.9.194.1
typescript 4.8.3

If I open the directory as a workspace in VS Code, and then open the file main.ts in an editor tab, and begin to type an import statement which uses the full URL for the standard library specifier in the import map, I get IntelliSense autocompletions. Here's a screenshot example to illustrate:

However, If I try to use the import map specifier for the same registry, the IntelliSense does not provide autocompletions beyond the specifier itself. It is aware that the mapped specifier exists:

But doesn't provide any further suggestions:

Further observations:

If I type out the complete path for a valid module in the registry using the literal URL, the module is cached as soon as I stop typing, without even needing to save the file:

But when using the import map specifier path to a module, I get a diagnostic signal (red wavy underlines) with conflicting information in the quick info box — it states that the dependency is resolved, but also that it is uncached or missing:

I must manually save the file and invoke the palette command "Deno: Cache Dependencies" in order to resolve the diagnostic issue:

I would, of course, like to see this behavior for export statements as well.

---

Related:

• Roadmap 3.0 #348
• lsp: import quick fixes and import suggestions consider import maps deno#10951
• Q3 2021 roadmap deno#11168
• LSP does not provide autocompletions for registry URLS in export statements deno#16805

[bartlomieju]

@jsejcksn do you still experience this problem with Deno v1.35? I believe this has been fixed.

[jsejcksn]

@jsejcksn do you still experience this problem with Deno v1.35? I believe this has been fixed.

@bartlomieju Sure: I'll budget some time today to test and report back here.

[jsejcksn]

@bartlomieju It now appears that autocompletion doesn't work at all with import map specifiers (except for modules that have been resolved in the same language server session?)

I recorded a screen capture of a basic test (attached to the bottom of this message), and here's text output of the files and software versions:

% ls -AF
.vscode/		import_map.json
deno.jsonc		main.ts

% cat .vscode/settings.json
{
  "deno.enable": true
}

% cat deno.jsonc
{
  "importMap": "./import_map.json"
}

% cat import_map.json
{
  "imports": {
    "std/": "https://deno.land/[email protected]/"
  }
}

% cat main.ts

% code --version
1.80.0
660393deaaa6d1996740ff4880f1bad43768c814
arm64

% code --list-extensions --show-versions | grep "deno"
[email protected]

% deno --version
deno 1.35.0 (release, aarch64-apple-darwin)
v8 11.6.189.7
typescript 5.1.6

gh_vscode_deno_752.mov

[bartlomieju]

@dsherret could you take a look here?