Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align serve, serveTls, and serveListener signatures with Deno.serve #3338

Closed
dsherret opened this issue Apr 28, 2023 · 3 comments · Fixed by #3381
Closed

Align serve, serveTls, and serveListener signatures with Deno.serve #3338

dsherret opened this issue Apr 28, 2023 · 3 comments · Fixed by #3381
Labels
suggestion a suggestion yet to be agreed

Comments

@dsherret
Copy link
Member

We should align these functions in http with Deno.serve's signature.

https://github.com/denoland/deno/blob/main/cli/tsc/dts/lib.deno.unstable.d.ts
@dsherret dsherret added the suggestion a suggestion yet to be agreed label Apr 28, 2023
@kt3k
Copy link
Member

kt3k commented May 16, 2023

How about just deprecating serve and serveTls after stabilizing Deno.serve?

ref. denoland/deno#19141

@lino-levan
Copy link
Contributor

Agree with @kt3k on this one. We should move people towards Deno.serve.

@lino-levan lino-levan mentioned this issue May 16, 2023
Merged
2 tasks
@dsherret
Copy link
Member Author

Yeah, going to close this.

@dsherret dsherret closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@dsherret dsherret mentioned this issue May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion a suggestion yet to be agreed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING(http/server): deprecate serve and serveTls lino-levan/deno_std
3 participants
@kt3k @dsherret @lino-levan