Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling to V8 10.4.132.19 #1012

Merged
merged 2 commits into from
Jul 12, 2022
Merged

Rolling to V8 10.4.132.19 #1012

merged 2 commits into from
Jul 12, 2022

Conversation

denobot
Copy link
Contributor

@denobot denobot commented Jun 22, 2022

No description provided.

@lucacasonato lucacasonato enabled auto-merge (squash) June 22, 2022 10:08
@denobot denobot changed the title Rolling to V8 10.4.132.11 Rolling to V8 10.4.132.13 Jun 23, 2022
@github-actions github-actions bot force-pushed the autoroll2 branch 3 times, most recently from 99d347c to 5a2a5f6 Compare June 26, 2022 10:08
@denobot denobot changed the title Rolling to V8 10.4.132.13 Rolling to V8 10.4.132.14 Jun 26, 2022
@github-actions github-actions bot force-pushed the autoroll2 branch 3 times, most recently from db6b664 to 87df278 Compare June 29, 2022 10:08
@denobot denobot changed the title Rolling to V8 10.4.132.14 Rolling to V8 10.4.132.15 Jun 29, 2022
@github-actions github-actions bot force-pushed the autoroll2 branch 2 times, most recently from b2055ff to 7fe86de Compare July 1, 2022 10:08
@denobot denobot changed the title Rolling to V8 10.4.132.15 Rolling to V8 10.4.132.16 Jul 1, 2022
auto-merge was automatically disabled July 1, 2022 14:08

Pull request was closed

@lucacasonato lucacasonato reopened this Jul 1, 2022
@github-actions github-actions bot force-pushed the autoroll2 branch 6 times, most recently from 8e62caa to 8f9c248 Compare July 7, 2022 10:08
@lucacasonato lucacasonato reopened this Jul 7, 2022
@lucacasonato lucacasonato enabled auto-merge (squash) July 7, 2022 14:05
@ry
Copy link
Member

ry commented Jul 7, 2022

V8 seems to have changed public API in a patch release... https://chromium-review.googlesource.com/c/v8/v8/+/3695584

@ry ry mentioned this pull request Jul 8, 2022
Merged
@github-actions github-actions bot force-pushed the autoroll2 branch 3 times, most recently from af8ccb9 to cc5bd1d Compare July 11, 2022 10:08
@denobot denobot changed the title Rolling to V8 10.4.132.16 Rolling to V8 10.4.132.19 Jul 12, 2022
bartlomieju
bartlomieju reviewed Jul 12, 2022
View reviewed changes
tests/test_api.rs

// We did not set wasm resolve callback so V8 uses the default one that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up for @andreubotella, this has changed in V8 in https://chromium-review.googlesource.com/c/v8/v8/+/3695584

I will add required bindings for that callback in a follow up

@lucacasonato lucacasonato merged commit d2db387 into main Jul 12, 2022
@lucacasonato lucacasonato deleted the autoroll2 branch July 12, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denobot @ry @lucacasonato @bartlomieju