Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support arm64 #100

Open
zz opened this issue Dec 28, 2020 · 10 comments
Open

Should support arm64 #100

zz opened this issue Dec 28, 2020 · 10 comments

Comments

@zz
Copy link

zz commented Dec 28, 2020

Docker image should have arm64

@LukeChannings
Copy link
Contributor

@zz if you're still interested, I have an ARM64 multi-arch image here: https://github.com/LukeChannings/docker-deno (lukechannings/deno on DockerHub)

@hayd
Copy link
Contributor

hayd commented Jan 22, 2021

Wow, that's great @LukeChannings .

So this (more or less) "just works" if you pass the --platform argument? Am I reading that correctly?

https://github.com/LukeChannings/docker-deno/blob/c4401697918050fd5a1f91ca3b21d7fcd62c5eea/.github/workflows/build-deno.yaml#L46

Is there a reason to do it like you do (downloading from releases) rather than as a multi-step?

@LukeChannings
Copy link
Contributor

Hey @hayd,

The --platform argument is for compiling x86/x86_64/aarch64, etc. It won't cross-compile for Windows/Darwin.

I push the artefact to the release so that the deno binary can be downloaded independently, since there is not yet an official aarch64 builds.

Of course, aarch64 builds of 1.7.0 aren't available atm because rusty_v8 isn't available yet and I've had trouble compiling it manually.

@seanaye
Copy link

seanaye commented Aug 9, 2021

Is there any update on this? I need to deploy Deno >= 1.12 in production and I'm having difficulty testing locally on my arm64 machine

@hayd
Copy link
Contributor

hayd commented Aug 9, 2021

The --platform argument is for compiling x86/x86_64/aarch64, etc. It won't cross-compile for Windows/Darwin.

I guess I never followed this, does this mean we wouldn't be able to build aarch64 on the denoland's ubuntu-large in CI?

That said, my suspicion is that maintaining arm64 will be much more palatable once there is native support for arm64 in GitHub actions (azure). Until then it's unlikely denoland will be able to maintain it. Though.. I don't speak for the team that is just my hunch.


The latest is that @LukeChannings is still maintaining https://github.com/LukeChannings/deno-arm64
and building arm64 binaries 💪

@felipecrs
Copy link
Contributor

I believe the current best way of handling this is by doing something like:

https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md

@hayd hayd mentioned this issue Dec 19, 2021
@theomessin
Copy link

Any update on this?

@loeffel-io
Copy link

loeffel-io commented Dec 4, 2022

+1

@comunidadio
Copy link

+1

It would be great to have official arm64 builds available as the architecture is getting more popular, both for development (recent Macbooks) and for servers (graviton etc).

@benatkin
Copy link

benatkin commented May 11, 2023

Hmm, recommendation here is to use a third party image. Same as how the alpine build is based on a third party image.

I'd like to see alpine removed from the official docker repository and arm64 builds added. That way those interested in using "The easiest, most secure JavaScript runtime" can be steered into using official images that are based only on official images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants