chore: update wpt #9907
Merged
chore: update wpt #9907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We didn't add a unit test for this, which didn't catch that we didn't update the typings for this. We also had #9777 open (without CI passing). From a stylistic perspective, we should put static methods at the end of the class definition. Can we follow this up with an update to the |
Yes we did - WPT tests it. |
But it doesn't test the types... and because we don't author in TypeScript anymore, we have no clue that we missed updating the types. 🤷 The following errors with type checking on: AbortSignal.abort() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests that are failing that are actionable:
ReadableStream: if pull rejects, it should error the streamTransformStream constructor should not call setters for highWaterMark or sizeRequired for #7819