Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move op state registration to workers #7696

Merged
merged 8 commits into from
Sep 28, 2020
Merged

refactor: move op state registration to workers #7696

merged 8 commits into from
Sep 28, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 26, 2020 •
edited
Loading

Depends on #7695

@bartlomieju bartlomieju changed the title [WIP] refactor: move op state registration to workers refactor: move op state registration to workers Sep 26, 2020
ry
ry reviewed Sep 26, 2020
View reviewed changes
cli/web_worker.rs
});
join_handle.join().expect("Failed to join worker thread");
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is desirable

ry
ry reviewed Sep 26, 2020
View reviewed changes
cli/ops/fs.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju requested a review from ry September 26, 2020 19:01
ry
ry approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 45d4fd4 into denoland:master Sep 28, 2020
@bartlomieju bartlomieju deleted the refactor_op_registration branch September 28, 2020 10:14
Soremwar pushed a commit to Soremwar/deno that referenced this pull request Oct 6, 2020
@bartlomieju @Soremwar
refactor: move op state registration to workers (denoland#7696)
bfefd58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry