Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(std): fix broken style guide link (#5204) #5211

Merged
merged 2 commits into from
May 12, 2020
Merged

fix(std): fix broken style guide link (#5204) #5211

merged 2 commits into from
May 12, 2020

Conversation

machadolucasvp
Copy link
Contributor

Closes #5204

missed link in /std for style guides

@CLAassistant
Copy link

CLAassistant commented May 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

Thanks for opening the PR @machadolucasvp ; make sure to run tools/format.py and tools/lint.py so CI is happy

@machadolucasvp
Copy link
Contributor Author

machadolucasvp commented May 11, 2020 •
edited
Loading

Thanks 😄, sorry for the delay

ry
ry approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ry ry merged commit eec0855 into denoland:master May 12, 2020
@ry ry mentioned this pull request May 12, 2020
Merged
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@machadolucasvp
fix(std): fix broken style guide link (denoland/deno#5211)
77ba788
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@machadolucasvp
fix: fix broken style guide link (denoland/deno#5211)
5f81019
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@machadolucasvp @caspervonb
fix: fix broken style guide link (denoland/deno#5211)
7caff44
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@machadolucasvp @caspervonb
fix: fix broken style guide link (denoland/deno#5211)
346d098
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@machadolucasvp @caspervonb
fix: fix broken style guide link (denoland/deno#5211)
add852c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@machadolucasvp @caspervonb
fix: fix broken style guide link (denoland/deno#5211)
d4320d7
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@machadolucasvp @caspervonb
fix: fix broken style guide link (denoland/deno#5211)
f3f53dc
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@machadolucasvp @denobot
fix: fix broken style guide link (denoland/deno#5211)
5f8753b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@machadolucasvp @denobot
fix: fix broken style guide link (denoland/deno#5211)
0acce6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style Guide Link not working (missing Style Guide md file)
4 participants
@machadolucasvp @CLAassistant @bartlomieju @ry