Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TypeScript 3.9 #4510

Merged
merged 7 commits into from
May 13, 2020
Merged

Update to TypeScript 3.9 #4510

merged 7 commits into from
May 13, 2020

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Mar 28, 2020

Preliminary WIP PR for updating to TypeScript 3.9. TypeScript found one bit of redundant code:

-    const remote = { hostname: "127.0.0.1", transport: "udp", ...addr };
+    const remote = { hostname: "127.0.0.1", ...addr };

The transport property was always getting overwritten because addr contains a transport.

@kitsonk
Copy link
Contributor Author

kitsonk commented Apr 29, 2020

Updated to 3.9.1-rc

@kitsonk kitsonk changed the title [WIP] Update to TypeScript 3.9 Update to TypeScript 3.9 May 12, 2020
@kitsonk kitsonk marked this pull request as ready for review May 12, 2020 23:06
@bartlomieju bartlomieju requested a review from ry May 12, 2020 23:28
ry
ry approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @kitsonk !

@ry ry merged commit 3d7552a into denoland:master May 13, 2020
@zhmushan zhmushan mentioned this pull request May 14, 2020
Closed
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@kitsonk
Update to TypeScript 3.9 (denoland/deno#4510)
f11c47c
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk
Update to TypeScript 3.9 (denoland/deno#4510)
f86af5b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk @caspervonb
Update to TypeScript 3.9 (denoland/deno#4510)
e53906e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@kitsonk @caspervonb
Update to TypeScript 3.9 (denoland/deno#4510)
13104fe
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Update to TypeScript 3.9 (denoland/deno#4510)
d5f4cd1
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Update to TypeScript 3.9 (denoland/deno#4510)
9c65ec8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @caspervonb
Update to TypeScript 3.9 (denoland/deno#4510)
45ba291
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@kitsonk @denobot
Update to TypeScript 3.9 (denoland/deno#4510)
9404b8b
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@kitsonk @denobot
Update to TypeScript 3.9 (denoland/deno#4510)
3d35339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitsonk @ry