Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Create child node_modules for conflicting dependency versions, respect aliases in package.json #24609

Merged
merged 6 commits into from
Jul 16, 2024
Merged

fix(cli): Create child node_modules for conflicting dependency versions, respect aliases in package.json #24609

merged 6 commits into from
Jul 16, 2024

Conversation

nathanwhit
Copy link
Member

Fixes #24419.

@nathanwhit nathanwhit requested a review from dsherret July 16, 2024 19:17
nathanwhit
nathanwhit commented Jul 16, 2024
View reviewed changes
cli/npm/managed/resolvers/local.rs
let dest_path =
remote.base_dir.join("node_modules").join(&remote.alias);

symlink_package_dir(&local_registry_package_path, &dest_path)?;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add to the setup cache

dsherret
dsherret reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This looks good to me, but I'm not sure why the CI is failing because of it.

dsherret
dsherret approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nathanwhit nathanwhit enabled auto-merge (squash) July 16, 2024 20:22
@nathanwhit nathanwhit merged commit c9da27e into denoland:main Jul 16, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
@nathanwhit @bartlomieju
fix(cli): Create child node_modules for conflicting dependency versio…
6e6c5ab 
…ns, respect aliases in package.json (#24609)

Fixes #24419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm workspaces: understand when to create child node_modules directories
2 participants
@nathanwhit @dsherret