Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts #24319

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts #24319

merged 2 commits into from
Jun 24, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 23, 2024

Towards #24236

@iuioiua iuioiua mentioned this pull request Jun 23, 2024
Open
satyarohith
satyarohith approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the stale log

@iuioiua @satyarohith
Update ext/node/polyfills/_fs/_fs_dir.ts
f60b6ea 
Co-authored-by: Satya Rohith <[email protected]>
Signed-off-by: Asher Gomez <[email protected]>
@iuioiua iuioiua enabled auto-merge (squash) June 24, 2024 05:50
@iuioiua iuioiua merged commit ff53506 into denoland:main Jun 24, 2024
17 checks passed
sbmsr pushed a commit to sbmsr/deno-1 that referenced this pull request Jul 2, 2024
@iuioiua @satyarohith @sbmsr
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts (…
9de9427 
…denoland#24319)

Towards denoland#24236

---------

Signed-off-by: Asher Gomez <[email protected]>
Co-authored-by: Satya Rohith <[email protected]>
@sbmsr sbmsr mentioned this pull request Jul 2, 2024
Closed
zebreus pushed a commit to zebreus/deno that referenced this pull request Jul 8, 2024
@iuioiua @satyarohith @zebreus
fix(ext/node): use primordials in ext/node/polyfills/_fs/_fs_dir.ts (…
db2df8b 
…denoland#24319)

Towards denoland#24236

---------

Signed-off-by: Asher Gomez <[email protected]>
Co-authored-by: Satya Rohith <[email protected]>
@iuioiua iuioiua deleted the primordials-ext-node-polyfills-_fs-_fs_dir branch July 12, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @satyarohith