refactor(ext): remove use of brotli::ffi
#24214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f-0b
commented
Jun 14, 2024
| unsafe { | ||
| brotli::ffi::compressor::BrotliEncoderCompressStream( | ||
| this.stm.stm, | ||
| brotli::ffi::compressor::BrotliEncoderOperation::BROTLI_OPERATION_PROCESS, |
There was a problem hiding this comment.
Removed the BROTLI_OPERATION_PROCESS call here. Tests still pass locally but I'm not sure if this is correct.
littledivy
reviewed
Jun 20, 2024
| unsafe { | ||
| brotli::ffi::compressor::BrotliEncoderCompressStream( | ||
| this.stm.stm, | ||
| brotli::ffi::compressor::BrotliEncoderOperation::BROTLI_OPERATION_PROCESS, |
littledivy
approved these changes
Jun 20, 2024
brotli::ffibrotli::ffi
sbmsr
pushed a commit
to sbmsr/deno-1
that referenced
this pull request
Jul 2, 2024
zebreus
pushed a commit
to zebreus/deno
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids issues when using these extensions in a project that also links to the C brotli library. See dropbox/rust-brotli#46.