Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct the url of the hello-world example #24139

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rroblf01
Copy link

@rroblf01 rroblf01 commented Jun 7, 2024

As you can see in issue #24130, when displaying the Deno help, the url for the Hello-world example is wrong.

In this Pull Request the URL is changed to the correct one.

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

@lucacasonato
Copy link
Member

@rroblf01 Thanks. Can you also update the link to https://deno.land/manual?

@rroblf01
Copy link
Author

rroblf01 commented Jun 7, 2024

Hello @lucacasonato

It is now updated.

@Devansh-Baghel
Copy link

Hello @rroblf01

In the same file where you made this change, there are two more mentions of this outdated link:

  1. in line 2443 where it says deno run https://examples.deno.land/hello-world.ts
  2. in line 2459 where it says curl https://examples.deno.land/hello-world.ts | deno run -",

Could you update those as well?

@rroblf01 rroblf01 changed the title Correct the url of the hello-world example fix: Correct the url of the hello-world example Jun 8, 2024
@rroblf01
Copy link
Author

rroblf01 commented Jun 8, 2024

Hello @Devansh-Baghel

I just updated the URLs

cli/args/flags.rs Outdated Show resolved Hide resolved
@rroblf01
Copy link
Author

Good afternoon @bartlomieju

Should I do something else in this case or should I just wait?

@rroblf01
Copy link
Author

Hi, is there anything else I should do or notify someone so I can merge this PR?

@thisisjofrank
Copy link
Contributor

thisisjofrank commented Aug 13, 2024

I've moved the examples files so they're now accessible on the docs site, and the example scripts no longer need to point to the raw github files and can instead point to https://docs.deno.com/examples/<script-name>.ts
There's a pr for this here: denoland/docs#706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants