perf(lsp): More granular locking of FileSystemDocuments
#23291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Apr 9, 2024
dsherret
reviewed
Apr 9, 2024
cli/lsp/documents.rs
Outdated
| @@ -1528,7 +1557,7 @@ impl Documents { | |||
| reqs | |||
| }); | |||
| self.dirty = false; | |||
| file_system_docs.dirty = false; | |||
| self.file_system_docs.set_dirty(false); | |||
There was a problem hiding this comment.
If something else comes along while this is running and marks it as dirty, then this will change it as not dirty. Is that a concern? Maybe instead it should swap the value and mark it as not dirty above? Something like:
let is_fs_docs_dirty = self.file_system_docs.set_dirty(false); // make sure this is always done
if is_fs_docs_dirty && !self.dirty {
|
Just took a profile of this change, I no longer see |
satyarohith
pushed a commit
that referenced
this pull request
Apr 11, 2024
Previously we locked the entire `FileSystemDocuments` even for lookups, causing contention. This was particularly bad because some of the hot ops (namely `op_resolve`) can end up hitting that lock under contention. This PR replaces the mutex with synchronization internal to `FileSystemDocuments` (an `AtomicBool` for the dirty flag, and then a `DashMap` for the actual documents). I need to think a bit more about whether or not this introduces any problematic race conditions.
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Apr 19, 2024
…3291) Previously we locked the entire `FileSystemDocuments` even for lookups, causing contention. This was particularly bad because some of the hot ops (namely `op_resolve`) can end up hitting that lock under contention. This PR replaces the mutex with synchronization internal to `FileSystemDocuments` (an `AtomicBool` for the dirty flag, and then a `DashMap` for the actual documents). I need to think a bit more about whether or not this introduces any problematic race conditions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we locked the entire
FileSystemDocumentseven for lookups, causing contention. This was particularly bad because some of the hot ops (namelyop_resolve) can end up hitting that lock under contention.This PR replaces the mutex with synchronization internal to
FileSystemDocuments(anAtomicBoolfor the dirty flag, and then aDashMapfor the actual documents).I need to think a bit more about whether or not this introduces any problematic race conditions.