Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update references to deno_std to use JSR #23239

Merged
merged 6 commits into from
Apr 10, 2024
Merged

chore: update references to deno_std to use JSR #23239

merged 6 commits into from
Apr 10, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Apr 5, 2024 •
edited
Loading

There are more uses of deno.land/std in the codebase, but for URL parsing purposes rather than network calls or documentation.

@iuioiua iuioiua requested a review from dsherret April 9, 2024 23:49
@iuioiua
Copy link
Collaborator Author

iuioiua commented Apr 9, 2024

Do you know why this isn't working, @dsherret?

@dsherret
Copy link
Member

Change typecheck_declarations_ns to do let context = TestContextBuilder::for_jsr().build();. Also, the test server needs deno_std to be in the fake JSR registry under tests/testdata/jsr/registry. I'd recommend just adding the bare minimum to get it compiling.

@iuioiua
Copy link
Collaborator Author

iuioiua commented Apr 10, 2024

It worked. Thank you. We should document this somewhere.

dsherret
dsherret approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit c6f1107 into denoland:main Apr 10, 2024
17 checks passed
@iuioiua iuioiua deleted the std-jsr branch April 10, 2024 21:27
satyarohith pushed a commit that referenced this pull request Apr 11, 2024
@iuioiua @satyarohith
chore: update references to deno_std to use JSR (#23239)
0cc0cd0 
There are more uses of `deno.land/std` in the codebase, but for URL
parsing purposes rather than network calls or documentation.
littledivy pushed a commit to littledivy/deno that referenced this pull request Apr 19, 2024
@iuioiua @littledivy
chore: update references to deno_std to use JSR (denoland#23239)
cf3e9b2 
There are more uses of `deno.land/std` in the codebase, but for URL
parsing purposes rather than network calls or documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @dsherret