fix(ext/fetch): clone second branch chunks in Body.clone() #20057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosc90
commented
Aug 4, 2023
| @@ -9,6 +9,7 @@ | |||
| const core = globalThis.Deno.core; | |||
| const ops = core.ops; | |||
| import * as webidl from "ext:deno_webidl/00_webidl.js"; | |||
| import { structuredClone } from "ext:deno_web/02_structured_clone.js"; | |||
There was a problem hiding this comment.
Are we using 02_structured_clone or 13_message_port one?
deno/ext/web/13_message_port.js
Line 332 in 72d9f06
ref: #12655
bartlomieju
reviewed
Aug 5, 2023
There was a problem hiding this comment.
@crowlKats please take a look as you're more knowledgable about this part of the codebase
littledivy
pushed a commit
to littledivy/deno
that referenced
this pull request
Aug 21, 2023
…20057) This PR makes `Body.clone()` spec compliant: https://fetch.spec.whatwg.org/#concept-body-clone > 1, Let « out1, out2 » be the result of [teeing](https://streams.spec.whatwg.org/#readablestream-tee) body’s [stream](https://fetch.spec.whatwg.org/#concept-body-stream). > ... > To tee a [ReadableStream](https://streams.spec.whatwg.org/#readablestream) stream, return ? [ReadableStreamTee](https://streams.spec.whatwg.org/#readable-stream-tee)(stream, true). --- Closes denoland#10994
littledivy
pushed a commit
that referenced
this pull request
Aug 21, 2023
This PR makes `Body.clone()` spec compliant: https://fetch.spec.whatwg.org/#concept-body-clone > 1, Let « out1, out2 » be the result of [teeing](https://streams.spec.whatwg.org/#readablestream-tee) body’s [stream](https://fetch.spec.whatwg.org/#concept-body-stream). > ... > To tee a [ReadableStream](https://streams.spec.whatwg.org/#readablestream) stream, return ? [ReadableStreamTee](https://streams.spec.whatwg.org/#readable-stream-tee)(stream, true). --- Closes #10994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Body.clone()spec compliant: https://fetch.spec.whatwg.org/#concept-body-cloneCloses #10994