Allow terminating an Isolate from another thread. #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
Mar 21, 2019
| @@ -85,6 +85,7 @@ pub trait Behavior { | |||
| /// JavaScript. | |||
| pub struct Isolate<B: Behavior> { | |||
| libdeno_isolate: *const libdeno::isolate, | |||
| shared_libdeno_isolate: Arc<Mutex<Option<*const libdeno::isolate>>>, | |||
There was a problem hiding this comment.
Should/can the Option be the outermost wrapper?
There was a problem hiding this comment.
The Option is atomically set to None when the Isolate is dropped. This prevents the IsolateHandle from using a disposed v8 isolate. see L100-101
core/isolate.rs
Outdated
| @@ -452,6 +463,28 @@ impl<B: Behavior> Future for Isolate<B> { | |||
| } | |||
| } | |||
|
|
|||
| /// SharedIsolate is a thread safe handle on an Isolate. It exposed thread safe V8 functions. | |||
| #[derive(Clone)] | |||
| pub struct SharedIsolate { | |||
There was a problem hiding this comment.
IsolateHandle sounds perfect.
|
I don't think this is related to this PR but there seems to be a flaky test. I can't figure out which exact test it is though https://ci.appveyor.com/project/deno/deno/builds/23251871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of deno core to forcefully terminate the execution of any script by calling
terminate_execution()from a different thread. This is also an API required to implement the Web WorkerWorker.prototype.terminate()function.Note: I'm not entirely sure about calling the thread safe isolate handle
SharedIsolate. (update: renamed toIsolateHandle)